Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add N/A label for no query and response even #948

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: Add N/A label for no query and response even #948

merged 1 commit into from
Oct 24, 2024

Conversation

janmichek
Copy link
Collaborator

Description

fixes #947

Demo

image

Checklist:

  • I have read and followed the Contributing Guide
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Deployed to https://pr-948-aescan.stg.service.aepps.com and https://pr-948-aescan-testnet.stg.service.aepps.com

@janmichek janmichek mentioned this pull request Oct 14, 2024
Merged
@janmichek janmichek force-pushed the Add-N/A-label-for-no-query-and-response-even branch from 76d9a89 to 7e7d85e Compare October 22, 2024 08:32
Liubov-crypto
Liubov-crypto approved these changes Oct 23, 2024
View reviewed changes
Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One more question, are these chinese symbols expected in this case ?

query

@janmichek
Copy link
Collaborator Author

LGTM.

One more question, are these chinese symbols expected in this case ?

query

Thank you! yeah, that seems to be correct

@janmichek janmichek merged commit 4150fc1 into develop Oct 24, 2024
2 checks passed
@janmichek janmichek deleted the Add-N/A-label-for-no-query-and-response-even branch October 24, 2024 07:27
@aeternity-bot aeternity-bot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add N/A label for no query and response event
2 participants
@janmichek @Liubov-crypto