Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pHash data from an older version of pHash w/the current version #14

Open
sunild opened this issue Jan 8, 2020 · 1 comment
Open

Comments

@sunild
Copy link

sunild commented Jan 8, 2020

Apologies, this isn't really a bug, it's more of a question. But it might be useful for someone else down the road...

I was thrilled to discover this project, as we've been using a very old version of pHash (https://github.com/hszcg/pHash-0.9.6, it has some patches applied to it for things I'm assuming you've since addressed here). We have over 2 million existing pHash values for photos in our database calculated by the older version.

We're also using a Ruby wrapper for the pHash lib to compare photos: https://github.com/toy/pHash

It seems that, for a given photo, the pHash values from our old version differ from the value that the latest version produces. It's different enough that we're not able to detect the images as being similar... Is this expected?

And more importantly, is it is possible that this could happen when the pHash library is updated in the future? That a pHash calculated from today's code could be different from one calculated in some future version of the lib?

@DarkShadow44
Copy link

Any new on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants