Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodenv codebase not updating after first run when revision is HEAD or a branch #20

Open
HP41 opened this issue Oct 15, 2021 · 1 comment

Comments

@HP41
Copy link
Contributor

HP41 commented Oct 15, 2021

Seems like git checkout in nodenv_user resource does not update git codebase after first run.

For eg, when HEAD or master is specified, it only checks out the very first time and thereafter never updates it. This can cause issues when you'd like to specify a newer node version than what is known by the nodenv version that was checked out at first run.

For tags, this should be good as it isn't a moving target like a branch or HEAD (remote).

Maybe it should use sync instead of checkout?
What are your thoughts?

@afaundez
Copy link
Owner

I think tags should be encouraged instead of using HEAD or master (or any other branch) to get a particular known state. But in that situation, you also want to upgrade, and the case you mentioned happens anyway. So I'll try to do a spec and define what should happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants