Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Option doMakeSameDomainsLinksRelative requires array, not boolean #23

Open
S1SYPHOS opened this issue Jun 25, 2022 · 1 comment
Open

Comments

@S1SYPHOS
Copy link

Hey there,
when looking at voku/htmlmin options, it's clear that doMakeSameDomainsLinksRelative is the only option receiving an array (not a boolean like the others). Therefore, it's logical that passing true / false inside config.php throws a TypeError:

Screenshot from 2022-06-25 10-42-51

I'd suggest passing every option 'as-is', or at least check for $option == 'doMakeSameDomainsLinksRelative' 😕

Cheers,
S1SYPHOS

@S1SYPHOS
Copy link
Author

FYI I opened an issue over at voku/htmlmin because I find the naming scheme somewhat inconsistent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant