Issues and questions about cases with no pointing model

[orionlee]

• there is a bug in initializing pointing model in TargetData. Details below.
• It'd be great if there is some discussion / guidance on how the absence of pointing model would affect constructed lightcurves. It looks like pointing model is not available for tpfs created from TESSCut, so it seems to be a common case.

---

Bug:

Line 218 below assumes source has pointing attribute.

• But currently, a source created from TESSCut does not have pointing attribute, generating exception.
• Thus the attempt to load one in line 221 is never executed.
• Users would not know anything, because the exception is silently caught (without, say, issuing a warning).

eleanor/eleanor/targetdata.py

Lines 217 to 223 in fa3c024

	try:
	if source.pointing is not None:
	self.pointing_model = source.pointing
	else:
	self.pointing_model = load_pointing_model(source.pm_dir, source.sector, source.camera, source.chip)
	except:
	self.pointing_model = None

• The bug possibly possibly has no material effect for now, at least for TESSCut-based source, because loading of pointing model in line 221 will not succeed anyway (returning None), as source.pm_dir is None.
• I am not sure if the bug might affect some other cases (where source.pointing does not exist and source.pm_dir is not None).