-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changedAttributes return entire deep object instead of only the changed field #74
Comments
Mind submitting a failing test? |
Hi Aidan, I was going through your test cases so I could write one but I got a little confused about what your implementation of From Backbone docs, Hence, assuming your test case scenario (and it's doc object) when we do an update, say But according to your tests, the Also when I run my sample code, I got a totally different object from your tests. What I got seems to be a hash of all nested object that have any attributes changed (which is more than the expect hash of changed attributes only). I'm sure I'm missing something here, but I can't got what it is. Would you care explaining what a call to Thanks for the help, Eric |
I'm having this problem as well. changedAttributes correctly returns "false" when no fields have changed. But when I change a single field, changeAttributes returns the entire object. |
Again, a pull request with a test case that can be worked against would be super helpful. Thanks! |
Thanks for the motivation, I finally cracked open the test suite! |
Ah, gotcha. See #72. |
Backbone 1.x (and 0.9.9) support has landed in master. Can you retest and see whether this is still a problem? |
Still happens with backbone 1.1.0 and backbone-nested 2.0.0 |
Here's naive solution in coffeescript that I'm using as workaround
|
Hi there,
After updating a sub-set of nested properties, calling model.changedAttributes will return the entire object instead of only the changed ones.
The text was updated successfully, but these errors were encountered: