Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Save settings #11

Open
Rycia opened this issue Jan 7, 2023 · 1 comment
Open

Feature request: Save settings #11

Rycia opened this issue Jan 7, 2023 · 1 comment

Comments

@Rycia
Copy link

Rycia commented Jan 7, 2023

Whenever BSMM closes (or crashes) the settings are never saved, such as what's selected under Miscellaneous if you want to have "reinstall installed mods" enabled or a custom folder path.

When opening it again, the custom path and any ticks made don't save.

You should try saving the user's settings to a json file or something as they are changed (not when the application is closed ect)

@affederaffe
Copy link
Owner

With f7418e7, exceptions are caught globally, so settings should always be saved on exit. I'm not a fan of saving them on change since it introduces unnecessary IO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants