Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media queries mq-col(flex) doesn't work #17

Open
darkkain opened this issue May 6, 2016 · 2 comments
Open

Media queries mq-col(flex) doesn't work #17

darkkain opened this issue May 6, 2016 · 2 comments

Comments

@darkkain
Copy link

darkkain commented May 6, 2016

In your media queries Stylus/Sass docs we able to do this:

@media (max-width: 61.24em) {
  li {
    @include mq-col(flex);
  }
}

But i got error when compile:
compile error

Double check in repo, it's doesn't have this functionality:
Not for Stulys
Not for Sass

@andre-mendes
Copy link

andre-mendes commented Jun 30, 2016

Hey @darkkain, I saw your comment and I took a look at the documentation and saw that there's no way to add "mq- col(flex)" in your Media queries. I dont know what you want to do but, you have to set "display: flex" in your parent container, not in your children elements (like the "LI" in your example). Thats why Flex Grid doesn't have a "mq-col(flex)"... I guess... 💃 You gotta set that in your "row" or "container". But as I said at the beginning , I don't know exactly what you want to do hehehe. Hope I helped you :)

@AlexisBRENON
Copy link
Collaborator

Hi @darkkain,

Looking at the code, the mq-col(flex) is not implemented for the moment on the contrary of col(flex).
Look at the differences between both implementation: mq-col and col

It's not very hard to fix, maybe you can do it and do a PR. Else, let me know, I'll do it when I have the time.

Kind regards,
Alexis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants