device:error WebXR session support error: sceneEl is null

[mkungla]

Description:

Everything here needs DOMContentLoaded before right?

aframe/src/utils/device.js

Line 28 in b9b6813

if (isWebXRAvailable) {

• A-Frame Version: 1.0.2
• Platform / Device: Firefox/WebXR API Emulator
• Reproducible Code Snippet or URL:

[dmarcos]

What URL, browser, headset?

[mkungla]

Firefox/WebXR API Emulator, haven't seen it with devices yet.

So I wrapped src/utils/device.js if (isWebXRAvailable) with document.addEventListener('DOMContentLoaded', () =>

aframe/src/utils/device.js

Lines 28 to 74 in b9b6813

	if (isWebXRAvailable) {
	var updateEnterInterfaces = function () {
	var sceneEl = document.querySelector('a-scene');
	if (sceneEl.hasLoaded) {
	sceneEl.components['vr-mode-ui'].updateEnterInterfaces();
	} else {
	sceneEl.addEventListener('loaded', updateEnterInterfaces);
	}
	};
	var errorHandler = function (err) {
	error('WebXR session support error: ' + err.message);
	};
	if (navigator.xr.isSessionSupported) {
	// Current WebXR spec uses a boolean-returning isSessionSupported promise
	navigator.xr.isSessionSupported('immersive-vr').then(function (supported) {
	supportsVRSession = supported;
	updateEnterInterfaces();
	}).catch(errorHandler);
	navigator.xr.isSessionSupported('immersive-ar').then(function (supported) {
	supportsARSession = supported;
	updateEnterInterfaces();
	}).catch(function () {});
	} else if (navigator.xr.supportsSession) {
	// Fallback for implementations that haven't updated to the new spec yet,
	// the old version used supportsSession which is rejected for missing
	// support.
	navigator.xr.supportsSession('immersive-vr').then(function () {
	supportsVRSession = true;
	updateEnterInterfaces();
	}).catch(errorHandler);
	navigator.xr.supportsSession('immersive-ar').then(function () {
	supportsARSession = true;
	updateEnterInterfaces();
	}).catch(function () {});
	} else {
	error('WebXR has neither isSessionSupported or supportsSession?!');
	}
	} else {
	if (navigator.getVRDisplays) {
	navigator.getVRDisplays().then(function (displays) {
	var sceneEl = document.querySelector('a-scene');
	vrDisplay = displays.length && displays[0];
	if (sceneEl) { sceneEl.emit('displayconnected', {vrDisplay: vrDisplay}); }
	});
	}
	}

and src/utils/tracked-controls.js

aframe/src/utils/tracked-controls.js

Lines 163 to 164 in b9b6813

	for (j = 0; j < profiles.length; j++) {
	controllerMatch = profiles[j].startsWith(idPrefix);

between these lines there is no error checking if controller.profiles[n] is undefined which is currently case with WebXR API Emulator

e.g.

if (!profiles[j]) { profiles[j] = 'oculus-touch' }

after adding these dirty fixes emulator works fine - almost.

[dmarcos]

I fixed the first issue on 7f017a3

Issue with controllers is something different. controller.profiles should be an array of strings. I believe existing entries with undefined values shouldn't happen. It looks like a bug in the WebXR implementation of the emulator.