Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review rating metadata on course and prof pages are not accurate #347

Closed
davidlhw opened this issue Dec 11, 2024 · 0 comments · Fixed by #350
Closed

review rating metadata on course and prof pages are not accurate #347

davidlhw opened this issue Dec 11, 2024 · 0 comments · Fixed by #350
Assignees
@davidlhw
Labels
bug Used to track bugs. This Label is used as a category on release notes.

Comments

@davidlhw
Copy link
Contributor

Describe the bug

After the introduction of #243, the query at @Rating on prof page & course page only contains a default of 10 items. hence the calculation on the FE obtained using the returned 10 items would be inaccurate
@davidlhw davidlhw added the bug Used to track bugs. This Label is used as a category on release notes. label Dec 11, 2024
@davidlhw davidlhw self-assigned this Dec 15, 2024
@davidlhw davidlhw mentioned this issue Dec 15, 2024
Merged
@davidlhw davidlhw linked a pull request Dec 15, 2024 that will close this issue
fix: prof and course review section inaccurate metadata #350
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidlhw davidlhw

Labels
bug Used to track bugs. This Label is used as a category on release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prof and course review section inaccurate metadata afterclass-io/afterclass.io
1 participant
@davidlhw