-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AgGrid 20.2.0 + Angular 8.0.0 + Ivy renderer fails for production builds #3159
Comments
I confirm, same error for me. |
Seems like it will get solved soon at |
Ahh, excellent news that it is being fixed upstream. Thanks @MicMicMon. I |
I think the issue should stay open until the fix is confirmed, what do you think? That may still require some adjustment on the ag-grid side. |
As discussed in angular/angular#29564, the author of AgGrid needs to re-package AgGrid using ng-packagr, in order to be compatible with Angular 8 Ivy. |
The problem appears to be fixed upstream in angular/core next. Tested with ag-grid-angular-cli-example with angular next (ng update @angular/core --next) and it compiles. The example throws an exception at runtime but that's a separate issue. |
Well I have stable Angular 8 and it doesn't work with ag-grid-angular 20.1.0. I'm getting the error mentioned above. I have Angular 8.0.1 and CLI 8.0.3. Should I upgrade to ag-grid 21?? |
Still not fixed in 21.0.1 |
We're an enterprise customer... could use this! It's the only thing preventing us from trying out Ivy in our product. |
This is an issue on the Angular side - see this comment from the related Angular CLI issue: angular/angular#29564 (comment) If you want to try Ivy with ag-Grid you'll need to reference |
I'm submitting a ...
Current behavior
Using Ag Grid in Angular 8 with Ivy renderer turned on causes a production (--prod) build to fail. Dev builds are fine.
Reproduce
Check out the ag-grid-angular-cli-example.
It will build fine until you add this to tsconfig.app.json
It will fail with the same error as in our app.
Please tell us about your environment:
Windows 10, Angular 8.0.0 + Ivy Renderer, Node 10.15.3, NPM 6.9.0
ag-Grid version: 20.2.0
Language: TypeScript 3.4.5
The text was updated successfully, but these errors were encountered: