Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing the row height and onRowHeightChanged() is not working in ag grid version 25.1.0 #4416

Closed
josephkuruvilla opened this issue Mar 24, 2021 · 3 comments

Comments

@josephkuruvilla
Copy link

josephkuruvilla commented Mar 24, 2021

I'm submitting a ... (check one with "x")

[] bug report => see 'Providing a Reproducible Scenario'
[] feature request => do not use Github for feature requests, see 'Customers of AG Grid'
[] support request => see 'Requesting Community Support'

Customers of AG Grid

If you are a customer you are entitled to use the AG Grid's customer support system (powered by Zendesk). Please use that channel for guaranteed response from the AG Grid team with regards bugs, feature requests and support.

Requesting Community Support

If you are not a customer of AG Grid, ag-grid staff will label your issue as managed-by-the-community. This means that AG Grid staff is not going to be actively looking into it and it will get closed if inactive for more than one month. The community is welcome to help with this question/support issue.

Providing a Reproducible Scenario
Accepted reproducible scenarios are

  • A description of the detailed steps to reproduce your behaviour in one of our examples in the docs.
  • A plunker

If you decide to send us a plunkr, from any example in our website use the plunkr button in there to fork your own code by following the steps below:

  • Select the framework that is appropriate to you from the drop-down
  • Open it in plunker. (Use the button plunker in our example)
  • Add your changes so that the behaviour is reproduced
  • Save and Freeze the plunker(On the top left corner)
  • Send us the link to the plunker(You can copy the URL from the browser)

Plunker example: https://plnkr.co/plunk/hMsg0z4xk3C2lejb

version 24.1.0

steps to reproduce:

  1. Double click on the cell first name
  2. it will open the cell editor
  3. when changing the input it will show the error message and it will change the row height
  4. when pressing the enter, cell editing will be stopped

This is the expected behaviour. but it's not working in the ag grid version 25.1.0
please find the below example
https://plnkr.co/plunk/erN9sn7kbZ4YDxgB

If reporting a bug make sure to state.

Current behaviour.
Expected behaviour. If possible back this up with our docs/examples if possible

Current behavior

When clicking on the cell in the table, cell editor is not opening when we have onRowHeightChanged(). It's not working in when we upgraded the version to 25.1.0. below 24 it was working fine.
gridApi.api.forEachNode(rowNode => rowNode.rowIndex === index && rowNode.setRowHeight(height))
gridApi.api.onRowHeightChanged()

Expected behavior

when we click on the cell in the table, the cell editor will be open and if we type something based on the criteria it will show the error messages. If the error message is too long the row height will get changed automatically. Now onRowHeightChanged() is not working fine with version of 25.1.0

Please tell us about your environment:

windows 10, Visual studio code , NPM, localhost:4000

  • AG Grid version: 25.1.0

yes its the most recent recent version

  • Browser:

yes all browsers are reproducing the same issue
[all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
  • [ES6/7 | ES5]
@makinggoodsoftware
Copy link
Contributor

Hi,

Your ticket has been flagged as in_zendesk, it means that we recognize this as an issue worth investigating so we have moved it to our official support channel for customers (zendesk)

We will carry on there with the investigation and we will update you as soon as possible.

Thanks

@kiril-matev
Copy link

Hello!

Thank you for reporting this - much appreciated!

Based on your description we've now reproduced this issue as a regression from v25.0.

We have added this bug to our backlog and we are tracking it with the following reference and description:
AG-5250 [Regression] When calling onRowHeightChanged(), custom cell editor closes

We try to fix bugs from one release to the next, so this should be fixed in the next release or the one after if it was raised too close to the next release date.

You can see the next release date on the product pipeline page:
https://www.ag-grid.com/ag-grid-pipeline/

Now that this issue is recorded in our backlog, we will soon close the GitHub issue because we will not update it when this bug is fixed in a future version of AG Grid. The best way to get an update on this item is to sign up for AG Grid new release notifications. Once a new AG Grid version is released, look for the item reference above (AG-XXXX) on the changelog page to see if it's resolved in that version:
https://www.ag-grid.com/ag-grid-changelog/

Thanks again for bringing this up with us - we appreciate your time!

@makinggoodsoftware
Copy link
Contributor

Hi,

In order to help us keep our issues queue clear, we are going to close this issue

The official way to check the status for an issue raised here is to check its AG-xxxx ID against our pipeline and changelog

…the pipeline (if not yet developed)

https://www.ag-grid.com/ag-grid-pipeline/

... or the changelog, (if the issue has been resolved)

https://www.ag-grid.com/ag-grid-changelog/

We keep issues raised in the pipeline through github open for a while so that the community can add some feedback to them, and close them when there is no activity for a while.

If you want to add further feedback to a closed ticket with this comment, we would recommend opening a new ticket as we don’t monitor closed issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants