Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to remark? #7

Open
agentofuser opened this issue May 24, 2019 · 1 comment
Open

Port to remark? #7

agentofuser opened this issue May 24, 2019 · 1 comment

Comments

@agentofuser
Copy link
Owner

Just found out about https://github.com/jake-low/remark-sectionize, which might have made this unnecessary 🤦‍♂️

In my defense, there's the classnames and stuff. Maybe contribute remark code upstream to remark-sectionize.

@nkuehn
Copy link

nkuehn commented Sep 26, 2019

Opinion: I don't see the rehype-based implementation as unnecessary. E.g. when using MDX, not all headings are generated on markdown-level, some could be the result of rendering a react component.
Update: Does not work since the react components are mdxhast and thereforce not touched by plugins working on hast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants