Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Tests: Update EDC System test to use DataManagement API for asset transfer #228

Closed
3 tasks done
cpeeyush opened this issue Apr 11, 2022 · 4 comments · Fixed by #221 or #227
Closed
3 tasks done

System Tests: Update EDC System test to use DataManagement API for asset transfer #228

cpeeyush opened this issue Apr 11, 2022 · 4 comments · Fixed by #221 or #227
Assignees
@cpeeyush
Labels
MVD story

Comments

@cpeeyush
Copy link

cpeeyush commented Apr 11, 2022 •
edited
Loading

Feature agera-edc/MinimumViableDataspace#30
edc-upstream-issue eclipse-edc#1120

Description

Currently EDC system tests has its own custom Api controller to perform contract negotiation, initiate transfer and fetch transfer. DataManagement API is capable to provide these functionalities hence it should be used instead of a custom implementation.

Acceptance Criteria

  • System test updated to use DataManagement API for asset transfer.
  • Sample 04.0-file transfer updated to use DataManagement API for asset transfer.
  • Removed existing custom implementation of ConsumerApiController.
@chrislomonico chrislomonico mentioned this issue Jun 13, 2022
Closed
6 tasks
@cpeeyush cpeeyush changed the title Update EDC System test to use DataManagement API for contract negotiation and asset transfer. Update EDC System test to use DataManagement API for contract negotiation and asset transfer Apr 11, 2022
@cpeeyush cpeeyush mentioned this issue Jun 13, 2022
Closed
@cpeeyush
Copy link
Author

cpeeyush commented Apr 12, 2022 •
edited
Loading

Upstream PR eclipse-edc#1113 adds changes related to using Data management API for contract negotiation.

@cpeeyush
Copy link
Author

cpeeyush commented Apr 14, 2022 •
edited
Loading

Agera PRs

@cpeeyush cpeeyush changed the title Update EDC System test to use DataManagement API for contract negotiation and asset transfer System Tests: Update EDC System test to use DataManagement API for asset transfer Apr 14, 2022
This was referenced Apr 14, 2022
Merged
Merged
@cpeeyush
Copy link
Author

cpeeyush commented Apr 14, 2022 •
edited
Loading

EDC Upstream PRs

@zeier zeier transferred this issue from agera-edc/MinimumViableDataspaceOld Apr 19, 2022
This was linked to pull requests Apr 19, 2022
SystemTests: Use Datamanagment API to initiate file transfer #221
Merged
Samples: Use Datamanagment API to initiate file transfer #227
Merged
@cpeeyush cpeeyush mentioned this issue Jun 13, 2022
Closed
3 tasks
@cpeeyush cpeeyush moved this from In Review to In Review Upstream in Agera EDC Apr 21, 2022
@cpeeyush
Copy link
Author

Both upstream PRs merged.

Repository owner moved this from In Review Upstream to Done in Agera EDC Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpeeyush cpeeyush

Labels
MVD story
Projects
Agera EDC
Status: Done
Milestone
No milestone
2 participants
@cpeeyush @chrislomonico