Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID Documents: Link to Self-Description #187

Closed
3 tasks
zeier opened this issue Jul 5, 2022 · 2 comments · Fixed by eclipse-edc/MinimumViableDataspace#76
Closed
3 tasks

DID Documents: Link to Self-Description #187

zeier opened this issue Jul 5, 2022 · 2 comments · Fixed by eclipse-edc/MinimumViableDataspace#76

Comments

@zeier
Copy link

zeier commented Jul 5, 2022

Feature #36
After #19, #186

Description

Each DID document should contain the link to the corresponding self-description.

A dataspace participant is identified via its DID document, which serves as the root from which additional information about a participant, like the self-description, can be retrieved.

Acceptance Criteria

  • DID documents (dataspace participants including dataspace authority) contain the link to the corresponding self-description.

Tasks

  • Add endpoint to serve self-description endpoint.
  • Test coverage.
@zeier zeier mentioned this issue Jul 5, 2022
8 tasks
@zeier zeier added this to Agera EDC Jul 5, 2022
@zeier zeier changed the title DID Document: Link to Self-Description DID Documents: Link to Self-Description Jul 6, 2022
@zeier zeier assigned cpeeyush and unassigned cpeeyush Jul 11, 2022
@zeier zeier moved this to Ready in Agera EDC Jul 12, 2022
@zeier zeier removed the team review label Jul 12, 2022
@marcgs marcgs moved this from Ready to Planned in Agera EDC Aug 10, 2022
@bscholtes1A
Copy link

Is this still needed?

In eclipse-edc/IdentityHub#23 we introduced the Identity Hub endpoint serving the self-description.

This GET endpoint has URL: IDENTITY_HUB_BASE_URL + /self-description, while IDENTITY_HUB_BASE_URL is already provided as a serviceEndpoint in the DID document.

So as long as, each DID document contains the URL of the identity hub, then it also indirectly contains the URL of the self-description endpoint.

@marcgs
Copy link

marcgs commented Aug 16, 2022

@bscholtes1A I think this is indeed required for correctness, as it is not mandatory that the self-description document is served by the Identity Hub.

@bscholtes1A bscholtes1A moved this from Planned to In Progress in Agera EDC Aug 25, 2022
@bscholtes1A bscholtes1A moved this from In Progress to In Review in Agera EDC Aug 25, 2022
@bscholtes1A bscholtes1A moved this from In Review to In Review Upstream in Agera EDC Aug 29, 2022
Repository owner moved this from In Review Upstream to Done in Agera EDC Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants