Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo deps for Pear/Rocket Rust Nightly regression workaround #84

Closed
rayrrr opened this issue Jul 20, 2020 · 0 comments · Fixed by #86
Closed

Update Cargo deps for Pear/Rocket Rust Nightly regression workaround #84

rayrrr opened this issue Jul 20, 2020 · 0 comments · Fixed by #86

Comments

@rayrrr
Copy link
Contributor

rayrrr commented Jul 20, 2020

Hello again. I recently had to start from scratch with Polaris again and it wouldn't build on Linux this time around even though it had built successfully on the same hardware a couple months back. Here's why:

rust-lang/rust#73293

This change to Rust created a regression in Pear (a Rocket subdependency), but thankfully a bugfix has been released. After following the directions in the above PR to take advantage of the bugfix, the build succeeded.

Basically, we need to update Pear to its latest version in the Cargo.lock file for Polaris to successfully build with Rust Nightly.

Something like cargo update -p pear && cargo update should do it, then we can put up a PR with the Cargo file changes.

Would you like to handle this, or for me to put up a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant