Skip to content

Commit fa6bd1c

Browse files
authored
Fix latest tag check (#426)
Our check that (when we make a new release) the Docker image is tagged with latest as well as the new semver version number, which we added in [v1.6.14][1] was broken. This was because we were not pulling the latest tag docker image during the check, so it was not present. Fixed in this commit. [1]: https://github.com/agilepathway/label-checker/releases/tag/v1.6.14
1 parent c9c005d commit fa6bd1c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/workflows/github_tag_and_release.yml

+2
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ jobs:
8181
# (it is important to have this check to catch any regression, e.g. if we move to a different way of releasing)
8282
id: check_docker_image_tagged_latest
8383
# yamllint disable rule:line-length
84+
# we need to pull both docker tags to do the check
8485
run: |
8586
docker pull ${{env.docker_repo}}:${{ needs.tag.outputs.semver }}
87+
docker pull ${{env.docker_repo}}:latest
8688
echo "IS_LATEST_TAGGED_CORRECTLY=$(docker image inspect ${{env.docker_repo}}:${{ needs.tag.outputs.semver }} | jq -r '.[] | (.RepoTags) | any( . == "${{env.docker_repo}}:latest") ')" >> "$GITHUB_OUTPUT"
8789
# yamllint enable rule:line-length
8890

0 commit comments

Comments
 (0)