Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null safety #292

Closed
Schwusch opened this issue Dec 9, 2020 · 7 comments
Closed

Migrate to null safety #292

Schwusch opened this issue Dec 9, 2020 · 7 comments

Comments

@Schwusch
Copy link
Collaborator

Schwusch commented Dec 9, 2020

We will have to support null safety at some point, and this ticket is for tracking that work.

@Schwusch
Copy link
Collaborator Author

Schwusch commented Dec 11, 2020

At the time of writing, shared_aws_api is listed as the 7:th most blocking package, blocking null safety migration:
https://github.com/dart-lang/sdk/wiki/Null-safety-migration-status

@Schwusch
Copy link
Collaborator Author

As it stands, we have 3 dependencies that are not migrated:

It seems package:http is close to a migrated release, and package:crypto seems to be migrated but no release.
I don't think package:build_runner needs to be migrated though, since it only runs when generating code?

@IchordeDionysos
Copy link

@Schwusch looks like you are now unblocked and should be able to migrate to null safety :)
Also you are now the 2nd most blocking package after dio

@pshichenko
Copy link

Any way I can help with this?

@Schwusch
Copy link
Collaborator Author

Schwusch commented Apr 13, 2021

@pshichenko There is a branch, null_safety, that you are welcome to fork and work on.
I currently have migrated the shared package, and there is some attempts to generate null safe code in the generator.
First step is to try to run the generator and observe the changes.
Feel free to ask questions on Gitter at dart-lang/server if you need quick answers.

@xvrh
Copy link
Collaborator

xvrh commented Apr 13, 2021

Hi Jonathan, if you are not working on it right now, I may give it a try starting from you branch.

@Schwusch
Copy link
Collaborator Author

I guess we can close this now as the null safe services has been published as 1.0.0 in #324
Better late than never 🦥 🏃
Thanks everyone who helped, @xvrh in particular ❤️
itsdone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants