Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if we could use serde for message serialisation #20

Open
ah- opened this issue Mar 6, 2018 · 1 comment
Open

Investigate if we could use serde for message serialisation #20

ah- opened this issue Mar 6, 2018 · 1 comment

Comments

@ah-
Copy link
Owner

ah- commented Mar 6, 2018

Currently the serialisation is a bunch of slightly sketchy mem transmutes and enums. It works ok, and is as fast as it gets, and produces little binary size overhead.

It would be interesting to see how it would look if we used serde in https://github.com/ah-/anne-key/blob/master/src/protocol.rs and e.g. https://github.com/ah-/anne-key/blob/master/src/bluetooth.rs#L69

@hdhoang
Copy link
Collaborator

hdhoang commented Mar 13, 2018

reddit discussion brought up abomonation, though it looks to be not no_std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants