Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate rate limiting to manage NSE API rate limits #33

Open
4 tasks
ahasunos opened this issue Sep 6, 2024 · 0 comments
Open
4 tasks

Integrate rate limiting to manage NSE API rate limits #33

ahasunos opened this issue Sep 6, 2024 · 0 comments

Comments

@ahasunos
Copy link
Owner

ahasunos commented Sep 6, 2024

Summary

What is the task or feature?
Integrate rate limiting to handle NSE API’s rate limits more effectively.

Objective

Why is this important?
I am not sure if NSE API imposes rate limits on API requests to prevent abuse and ensure fair usage. But, implementing rate limiting within our client will help manage limits (if any) effectively, avoid hitting rate limits, and ensure reliable access to the API without interruptions.

Approach

How should this be implemented?

  1. Analyze the current NSE API rate limits and understand the constraints (e.g., requests per minute/hour).
  2. Choose a rate limiting strategy (e.g., token bucket, leaky bucket).
  3. Implement rate limiting in the API client to automatically handle and queue requests to stay within rate limits.
  4. Add logic to handle rate limit exceeded errors gracefully and retry after the appropriate delay.
  5. Document the rate limiting configuration and behavior in the project’s documentation.

Acceptance Criteria

  • Integrate rate limiting based on NSE API’s rate limit specifications.
  • Ensure that the client automatically handles rate limit errors and retries requests as needed.
  • Configure rate limiting parameters and provide options for adjusting them.
  • Document the rate limiting implementation and its usage.

Additional Information

Priority: Low

Dependencies: Understanding of NSE API’s rate limit policies and any existing request handling mechanisms.

Notes: Ensure the rate limiting logic does not significantly impact the performance or user experience and that it handles edge cases effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant