Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in save_to_file method of CRS object #1

Open
smherwig opened this issue Nov 12, 2024 · 0 comments
Open

Bug in save_to_file method of CRS object #1

smherwig opened this issue Nov 12, 2024 · 0 comments

Comments

@smherwig
Copy link

In objects.py, I think the save_to_file method of CRS has a copy-paste mistake. Specifically, lines 135-136 are storing the h_parameters in the sqlite3 database. Currently these lines are:

cur.execute("INSERT INTO crs(rowid, pk) VALUES(?,?)",(2*i+3,self.g1.to_binary()))
cur.execute("INSERT INTO crs(rowid, pk) VALUES(?,?)",(2*i+4,self.g2.to_binary()))

However, I believe they should be:

cur.execute("INSERT INTO crs(rowid, pk) VALUES(?,?)",(2*i+3,self.h_parameters_g1[i].to_binary()))
cur.execute("INSERT INTO crs(rowid, pk) VALUES(?,?)",(2*i+4,self.h_parameters_g2[i].to_binary()))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant