Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

refactoring Node: seperate class for the collection of Nodes? #12

Open
Lyla-Fischer opened this issue Jun 1, 2019 · 1 comment
Open

refactoring Node: seperate class for the collection of Nodes? #12

Lyla-Fischer opened this issue Jun 1, 2019 · 1 comment

Comments

@Lyla-Fischer
Copy link
Collaborator

I just notice that the Node class is very large, and it has a lot of classmethods. I feel like a lot of the classmethods relate to dealing with the collection of nodes in a class variable, which feels like it should be in a seperate class to me (a collection of Nodes is not a Node), even if that class is a singleton.
@ahopkins
Copy link
Owner

ahopkins commented Jun 1, 2019

Makes sense.

@Lyla-Fischer Lyla-Fischer mentioned this issue Jun 8, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahopkins @Lyla-Fischer