397 as a dev I want to have a dev menu for demo purposes #399

SamuelPelletierEvraire · 2025-01-06T18:13:42Z

DevMenu
Feature:

Confirm all and unconfirm all button accessible on formPage.
LoadData accessible on the HomePage to make the data load on the form page. (Organisation data don't load because the json file don't have the good form)
Download json file (Working whit backend only) (Only available on formPage)
Test alertBanner message (All message should be avalaible) (Available on all page)

To active the devMenu you need to create a use call "demoFertiscan" and log with it.

add devstore add fill field with data add dev menu add dev menu when user demo is selected in login modal

move labelData.json to the root of the public folder make the button appear only on the good page

remove demomessage from layout.tsx Need to fix for labelDataValidator

remove console.log Fix test

ChromaticPanic

Looks like you need to run the code formatter for the files

ChromaticPanic · 2025-01-07T18:00:23Z

src/app/label-data-validation/page.tsx

@@ -10,86 +10,103 @@ import axios from "axios";
 import Cookies from "js-cookie";
 import { useRouter } from "next/navigation";
 import { useEffect, useState } from "react";
+import useDevStore from "@/stores/devStore";

 function LabelDataValidationPage() {


might as well update this to arrow function syntax
const LabelDataValidationPage = () =>

ChromaticPanic · 2025-01-07T18:02:13Z

src/app/page.tsx

@@ -11,6 +12,7 @@ import { useTranslation } from "react-i18next";
 function HomePage() {


use arrow function syntax
const HomePage = () =>

ChromaticPanic · 2025-01-07T18:07:43Z

src/components/DevMenu.tsx

+      if (
+        key === "errors" &&
+        typeof obj[key] === "object" &&
+        obj[key] !== null
+      ) {


null check should probably go before the type check

also better to use != null instead of !== null because != null will work with both null and undefined

if ( key === "errors" && obj[key] != null && typeof obj[key] === "object" ) {

ChromaticPanic · 2025-01-07T18:12:29Z

src/components/DevMenu.tsx

+        }
+      } else if (typeof obj[key] === "object" && obj[key] !== null) {
+        const nestedErrors = extractErrorKeys(obj[key] as Record<string, unknown>, currentKey);


} else if (obj[key] != null && typeof obj[key] === "object") {

k-allagbe

Overall we should avoid coupling the dev menu code with the real code to avoid breaking stuff. That would also ease developing both independently.

On that premise,

instead of coupling the visibility of the dev menu with the login / sign up process, we could try tying it to the cookie
instead of embedding the label data loading into the existing code, we could try creating dev mode twins for the relevant api routes
there probably should be an option to change the backend url

k-allagbe · 2025-01-07T18:05:48Z

src/app/label-data-validation/page.tsx

    };
+    fetchData();
+    // eslint-disable-next-line react-hooks/exhaustive-deps


Let's try to avoid disabling lints as much as possible.

Yeah I'm agree but those are needed to avoid adding other const to the use effect that cause error.

It is for avoiding a warning.

k-allagbe · 2025-01-07T18:23:48Z

src/components/AuthComponents/LoginModal.tsx

-    });
+      login(username, password).then((message) => {
+        if (message === "" && username === "demoFertiscan"){
+          useDevStore.getState().setIsDemoUser(true);


Have you tested that this is working as expected?

k-allagbe · 2025-01-07T18:25:37Z

src/components/AuthComponents/LoginModal.tsx

-      setErrorMessage(message);
-    });
+      login(username, password).then((message) => {
+        if (message === "" && username === "demoFertiscan"){


What about sign up? Because our sign up process logs in the user automatically.

k-allagbe · 2025-01-07T18:30:29Z

src/components/AuthComponents/LoginModal.tsx

+          useDevStore.getState().setIsDemoUser(true);
+          console.log("Dev mod enabled");
+        }else{
+          console.log(message);


Have you tested that when we log out and log a user other than demoFertiscan in an environment other than development during the same session, the dev menu doesn't show?

k-allagbe · 2025-01-07T18:31:45Z

src/components/LabelDataValidator.tsx

+      });
+      setLabelData({ ...labelData });
+    },
+    // eslint-disable-next-line react-hooks/exhaustive-deps


Let's try to avoid disabling lints as much as possible. There must be a workaround to achieve what you want.

k-allagbe · 2025-01-07T18:45:58Z

src/components/AuthComponents/LoginModal.tsx

-      setErrorMessage(message);
-    });
+      login(username, password).then((message) => {
+        if (message === "" && username === "demoFertiscan"){


Instead of a checking a single user, we could check a prefix like demo_. That would give us more options. Moreover, consider using an env var to avoid hardcoding.

No the point of this is that the use can use it when showing the app during reunions. But yes the env can be a good idea to add.

…n when in dev env

SamuelPelletierEvraire added 8 commits January 3, 2025 13:00

add the file to fill the data in the form

9d559fe

add devstore add fill field with data add dev menu add dev menu when user demo is selected in login modal

add confirm all / unconfirm all button

fcbe0fb

move labelData.json to the root of the public folder make the button appear only on the good page

implement show alert demo

be3c234

remove demomessage from layout.tsx Need to fix for labelDataValidator

add download file in json format

05c2752

fix design list alert

8de1bf6

fix error in authentification translation file in french

41d319b

remove comment on dev menu page

63bec39

add devMenu traduction

54c1896

SamuelPelletierEvraire requested review from ChromaticPanic and k-allagbe January 6, 2025 18:13

SamuelPelletierEvraire self-assigned this Jan 6, 2025

SamuelPelletierEvraire requested a review from a team as a code owner January 6, 2025 18:13

SamuelPelletierEvraire linked an issue Jan 6, 2025 that may be closed by this pull request

As a dev, I want to have a dev menu for demo purposes. #397

Open

3 tasks

SamuelPelletierEvraire had a problem deploying to experimental January 6, 2025 18:13 — with GitHub Actions Failure

SamuelPelletierEvraire had a problem deploying to experimental January 6, 2025 18:27 — with GitHub Actions Failure

SamuelPelletierEvraire had a problem deploying to experimental January 7, 2025 13:47 — with GitHub Actions Failure

SamuelPelletierEvraire force-pushed the 397-as-a-dev-i-want-to-have-a-dev-menu-for-demo-purposes branch from 3bca662 to 5326863 Compare January 7, 2025 14:14

SamuelPelletierEvraire had a problem deploying to experimental January 7, 2025 14:14 — with GitHub Actions Failure

fix lint

b72d8a8

remove console.log Fix test

SamuelPelletierEvraire force-pushed the 397-as-a-dev-i-want-to-have-a-dev-menu-for-demo-purposes branch from 5326863 to b72d8a8 Compare January 7, 2025 14:43

SamuelPelletierEvraire temporarily deployed to experimental January 7, 2025 14:43 — with GitHub Actions Inactive

ChromaticPanic requested changes Jan 7, 2025

View reviewed changes

k-allagbe reviewed Jan 7, 2025

View reviewed changes

made some modification as requested by comment on pr

f3216a2

SamuelPelletierEvraire had a problem deploying to experimental January 8, 2025 16:08 — with GitHub Actions Failure

Change made on login demo fertiscan check by token. You can now log i…

7c1005c

…n when in dev env

SamuelPelletierEvraire had a problem deploying to experimental January 8, 2025 17:39 — with GitHub Actions Failure

add env detection for devMenu

d760e6e

SamuelPelletierEvraire had a problem deploying to experimental January 8, 2025 17:49 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

397 as a dev I want to have a dev menu for demo purposes #399

397 as a dev I want to have a dev menu for demo purposes #399

SamuelPelletierEvraire commented Jan 6, 2025 •

edited

Loading

ChromaticPanic left a comment •

edited

Loading

ChromaticPanic Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

ChromaticPanic Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

ChromaticPanic Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

ChromaticPanic Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

k-allagbe left a comment •

edited

Loading

k-allagbe Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

SamuelPelletierEvraire Jan 8, 2025

SamuelPelletierEvraire Jan 8, 2025

k-allagbe Jan 7, 2025

k-allagbe Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

k-allagbe Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

k-allagbe Jan 7, 2025

k-allagbe Jan 7, 2025

SamuelPelletierEvraire Jan 8, 2025

		@@ -11,6 +12,7 @@ import { useTranslation } from "react-i18next";
		function HomePage() {

397 as a dev I want to have a dev menu for demo purposes #399

Are you sure you want to change the base?

397 as a dev I want to have a dev menu for demo purposes #399

Conversation

SamuelPelletierEvraire commented Jan 6, 2025 • edited Loading

ChromaticPanic left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k-allagbe left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamuelPelletierEvraire commented Jan 6, 2025 •

edited

Loading

ChromaticPanic left a comment •

edited

Loading

k-allagbe left a comment •

edited

Loading