Skip to content

Commit 06f3e18

Browse files
committed
fix: Remove OpenSSL dependency, use Rust TLS
Introduced here: #1934 `cargo deny` normally prevents this but it wasn't being enforced last night. We avoid OpenSSL because: - It needs to be dynamically linked, so we have to build for a specific version. - We have to stay on top of CVEs. The Rust TLS is considered more secure. - It interferes with other libraries trying to do static linking. For example we cannot statically link `llama.cpp` if we dynamically link OpenSSL.
1 parent 3c6fc6f commit 06f3e18

File tree

3 files changed

+4
-109
lines changed

3 files changed

+4
-109
lines changed

Cargo.lock

Lines changed: 2 additions & 107 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/llm/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ assert_matches = "1.5"
133133
criterion = { version = "0.3", features = ["html_reports"] }
134134
hf-hub = { workspace = true }
135135
proptest = "1.5.0"
136-
reqwest = { version = "0.12", default-features = false, features = ["json", "stream", "rustls-tls"] }
136+
reqwest = { version = "0.12.22", default-features = false, features = ["json", "stream", "rustls-tls"] }
137137
rstest = "0.18.2"
138138
rstest_reuse = "0.7.0"
139139
tempfile = "3.17.1"

lib/runtime/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ socket2 = { version = "0.5.8" }
7777
[dev-dependencies]
7878
assert_matches = { version = "1.5.0" }
7979
env_logger = { version = "0.11" }
80-
reqwest = { version = "0.12.22", features = ["json"] }
80+
reqwest = { version = "0.12.22", default-features = false, features = ["json", "stream", "rustls-tls"] }
8181
rstest = { version = "0.23.0" }
8282
temp-env = { version = "0.3.6" }
8383

0 commit comments

Comments
 (0)