Skip to content

Commit 57d24a1

Browse files
authored
build: Removing shell configuration violations. It's bad practice to hardcod… (#1973)
1 parent 182d3b5 commit 57d24a1

File tree

4 files changed

+0
-7
lines changed

4 files changed

+0
-7
lines changed

container/Dockerfile.sglang

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ RUN pyright --help > /dev/null 2>&1
191191
# Enable Git operations in the /workspace directory
192192
RUN printf "[safe]\n directory=/workspace\n" > /root/.gitconfig
193193

194-
RUN ln -sf /bin/bash /bin/sh
195194

196195
### BUILDS ###
197196

container/Dockerfile.tensorrt_llm

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,6 @@ RUN pyright --help > /dev/null 2>&1
176176
# Enable Git operations in the /workspace directory
177177
RUN printf "[safe]\n directory=/workspace\n" > /root/.gitconfig
178178

179-
RUN ln -sf /bin/bash /bin/sh
180-
181179
# Rust build/dev dependencies
182180
RUN apt-get update && \
183181
apt-get install --no-install-recommends -y \

container/Dockerfile.vllm

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,6 @@ RUN pyright --help > /dev/null 2>&1
228228
# Enable Git operations in the /workspace directory
229229
RUN printf "[safe]\n directory=/workspace\n" > /root/.gitconfig
230230

231-
RUN ln -sf /bin/bash /bin/sh
232-
233231
# Install prometheus
234232
ARG PROM_VERSION=3.4.1
235233
RUN apt-get update && apt-get install -y --no-install-recommends \

container/Dockerfile.vllm_v1

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,6 @@ RUN pyright --help > /dev/null 2>&1
210210
# Enable Git operations in the /workspace directory
211211
RUN printf "[safe]\n directory=/workspace\n" > /root/.gitconfig
212212

213-
RUN ln -sf /bin/bash /bin/sh
214-
215213
# Install prometheus
216214
ARG PROM_VERSION=3.4.1
217215
RUN apt-get update && apt-get install -y --no-install-recommends \

0 commit comments

Comments
 (0)