Skip to content

Commit 8463d2e

Browse files
committed
fix: replace hard coded dynamo namespace with env var
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
1 parent dcd331a commit 8463d2e

File tree

11 files changed

+39
-17
lines changed

11 files changed

+39
-17
lines changed

components/backends/llama_cpp/src/dynamo/llama_cpp/main.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import argparse
77
import logging
8+
import os
89
import sys
910
from typing import Optional
1011

@@ -17,7 +18,8 @@
1718

1819
from . import __version__
1920

20-
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
21+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
22+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.backend.generate"
2123

2224
configure_dynamo_logging()
2325

components/backends/sglang/src/dynamo/sglang/args.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020

2121
configure_dynamo_logging()
2222

23-
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
23+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
24+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.backend.generate"
25+
2426
DYNAMO_ARGS: Dict[str, Dict[str, Any]] = {
2527
"endpoint": {
2628
"flags": ["--endpoint"],

examples/multimodal/components/encode_worker.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,9 @@ async def async_init(self, runtime: DistributedRuntime):
176176

177177
@classmethod
178178
def parse_args(cls) -> Tuple[argparse.Namespace, Config]:
179-
DEFAULT_ENDPOINT = "dyn://dynamo.encoder.generate"
180-
DEFAULT_DOWNSTREAM_ENDPOINT = "dyn://dynamo.llm.generate"
179+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
180+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.encoder.generate"
181+
DEFAULT_DOWNSTREAM_ENDPOINT = f"dyn://{DYN_NAMESPACE}.llm.generate"
181182

182183
parser = FlexibleArgumentParser(
183184
description="vLLM based encoder for Dynamo LLM."

examples/multimodal/components/processor.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ class Processor(ProcessMixIn):
6363

6464
@classmethod
6565
def parse_args(cls) -> Tuple[argparse.Namespace, Config]:
66-
DEFAULT_ENDPOINT = "dyn://dynamo.processor.generate"
67-
DEFAULT_DOWNSTREAM_ENDPOINT = "dyn://dynamo.encoder.generate"
66+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
67+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.processor.generate"
68+
DEFAULT_DOWNSTREAM_ENDPOINT = f"dyn://{DYN_NAMESPACE}.encoder.generate"
6869

6970
parser = FlexibleArgumentParser(
7071
description="vLLM based processor for Dynamo LLM."

examples/multimodal/components/video_encode_worker.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,9 @@ async def async_init(self, runtime: DistributedRuntime):
217217

218218
@classmethod
219219
def parse_args(cls) -> Tuple[argparse.Namespace, Config]:
220-
DEFAULT_ENDPOINT = "dyn://dynamo.encoder.generate"
221-
DEFAULT_DOWNSTREAM_ENDPOINT = "dyn://dynamo.llm.generate"
220+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
221+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.encoder.generate"
222+
DEFAULT_DOWNSTREAM_ENDPOINT = f"dyn://{DYN_NAMESPACE}.llm.generate"
222223

223224
parser = FlexibleArgumentParser(
224225
description="vLLM based encoder for Dynamo LLM."

examples/multimodal/components/worker.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,17 +84,23 @@ def parse_args(cls) -> Tuple[argparse.Namespace, Config]:
8484

8585
# use endpoint_overwrite to set the default endpoint based on worker type
8686
def endpoint_overwrite(args):
87+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
8788
# default endpoint for this worker
8889
if args.worker_type == "prefill":
89-
args.endpoint = args.endpoint or "dyn://dynamo.llm.generate"
90+
args.endpoint = args.endpoint or f"dyn://{DYN_NAMESPACE}.llm.generate"
9091
elif args.worker_type == "decode":
91-
args.endpoint = args.endpoint or "dyn://dynamo.decoder.generate"
92+
args.endpoint = (
93+
args.endpoint or f"dyn://{DYN_NAMESPACE}.decoder.generate"
94+
)
9295
elif args.worker_type == "encode_prefill":
93-
args.endpoint = args.endpoint or "dyn://dynamo.encoder.generate"
96+
args.endpoint = (
97+
args.endpoint or f"dyn://{DYN_NAMESPACE}.encoder.generate"
98+
)
9499
# set downstream endpoint for disaggregated workers
95100
if args.enable_disagg:
96101
args.downstream_endpoint = (
97-
args.downstream_endpoint or "dyn://dynamo.decoder.generate"
102+
args.downstream_endpoint
103+
or f"dyn://{DYN_NAMESPACE}.decoder.generate"
98104
)
99105

100106
return args

examples/multimodal/utils/args.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929

3030
logger = logging.getLogger(__name__)
3131

32-
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
32+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
33+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.backend.generate"
3334

3435

3536
class Config:

lib/bindings/python/examples/hello_world/server_sglang.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import argparse
2323
import asyncio
24+
import os
2425
import sys
2526

2627
import sglang
@@ -30,7 +31,8 @@
3031
from dynamo.llm import ModelInput, ModelType, register_llm
3132
from dynamo.runtime import DistributedRuntime, dynamo_worker
3233

33-
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
34+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
35+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.backend.generate"
3436
DEFAULT_MODEL = "Qwen/Qwen3-0.6B"
3537
DEFAULT_TEMPERATURE = 0.7
3638

lib/bindings/python/examples/hello_world/server_sglang_static.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
import argparse
1515
import asyncio
16+
import os
1617
import sys
1718

1819
import sglang
@@ -21,7 +22,8 @@
2122

2223
from dynamo.runtime import DistributedRuntime, dynamo_worker
2324

24-
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
25+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
26+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.backend.generate"
2527
DEFAULT_MODEL = "Qwen/Qwen3-0.6B"
2628
DEFAULT_TEMPERATURE = 0.7
2729

lib/bindings/python/examples/hello_world/server_sglang_tok.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
import argparse
2424
import asyncio
25+
import os
2526
import sys
2627
import time
2728

@@ -34,7 +35,8 @@
3435
from dynamo.llm import ModelInput, ModelType, register_llm
3536
from dynamo.runtime import DistributedRuntime, dynamo_worker
3637

37-
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
38+
DYN_NAMESPACE = os.environ.get("DYN_NAMESPACE", "dynamo")
39+
DEFAULT_ENDPOINT = f"dyn://{DYN_NAMESPACE}.backend.generate"
3840
DEFAULT_MODEL = "Qwen/Qwen3-0.6B"
3941

4042

0 commit comments

Comments
 (0)