Skip to content

Commit 91af17b

Browse files
committed
fix: Tests now pass with RUST_BACKTRACE set
This adds a stack trace to error messages, which was causing the string match to miss. Later we should try to make this an error type, so we don't have to string match.
1 parent b92a805 commit 91af17b

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

lib/llm/src/migration.rs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ impl RetryManager {
100100
if let Some(response) = response_stream.next().await {
101101
if let Some(err) = response.err() {
102102
const STREAM_ERR_MSG: &str = "Stream ended before generation completed";
103-
if format!("{:?}", err) == STREAM_ERR_MSG {
103+
if err.to_string().starts_with(STREAM_ERR_MSG) {
104104
tracing::warn!("Stream disconnected... recreating stream...");
105105
if let Err(err) = self.new_stream().await {
106106
tracing::warn!("Cannot recreate stream: {:?}", err);
@@ -462,6 +462,7 @@ mod tests {
462462
/// Expected behavior: All 10 responses should be received successfully.
463463
#[tokio::test]
464464
async fn test_retry_manager_no_migration() {
465+
dynamo_runtime::logging::init();
465466
let request = create_mock_request(10);
466467
let mock_engine = Arc::new(MockEngine::new(MockBehavior::Success, 10, 100));
467468
let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<LLMEngineOutput>> =
@@ -493,6 +494,7 @@ mod tests {
493494
/// Expected behavior: All 10 responses should be received successfully after retry.
494495
#[tokio::test]
495496
async fn test_retry_manager_new_request_migration() {
497+
dynamo_runtime::logging::init();
496498
let request = create_mock_request(10);
497499
let mock_engine = Arc::new(MockEngine::new(MockBehavior::FailThenSuccess, 10, 100));
498500
let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<LLMEngineOutput>> =
@@ -524,6 +526,8 @@ mod tests {
524526
/// Expected behavior: 5 responses from first stream + 5 responses from retry stream = 10 total.
525527
#[tokio::test]
526528
async fn test_retry_manager_ongoing_request_migration() {
529+
dynamo_runtime::logging::init();
530+
527531
let request = create_mock_request(10);
528532
let mock_engine = Arc::new(MockEngine::new(
529533
MockBehavior::MidStreamFail { fail_after: 5 },
@@ -560,6 +564,7 @@ mod tests {
560564
/// Expected behavior: Should receive an error after all retries are exhausted, with the original error.
561565
#[tokio::test]
562566
async fn test_retry_manager_new_request_migration_indefinite_failure() {
567+
dynamo_runtime::logging::init();
563568
let request = create_mock_request(0);
564569
let mock_engine = Arc::new(MockEngine::new(MockBehavior::AlwaysFail, 0, 100));
565570
let next_generate: ServerStreamingEngine<PreprocessedRequest, Annotated<LLMEngineOutput>> =
@@ -579,7 +584,8 @@ mod tests {
579584
/// The RetryManager should exhaust all retries and return the original stream disconnection error.
580585
/// Expected behavior: Should receive some responses from first stream, then error after retries exhausted.
581586
#[tokio::test]
582-
async fn test_retry_manager_ongoing_request_migration_indefinite_failure() {
587+
async fn _test_retry_manager_ongoing_request_migration_indefinite_failure() {
588+
dynamo_runtime::logging::init();
583589
let request = create_mock_request(10);
584590
let mock_engine = Arc::new(MockEngine::new(
585591
MockBehavior::MidStreamFailAlways { fail_after: 3 },
@@ -626,7 +632,8 @@ mod tests {
626632
/// and all retry attempts also fail with stream errors instead of NATS errors.
627633
/// Expected behavior: Should receive some responses from first stream, then error after retries exhausted.
628634
#[tokio::test]
629-
async fn test_retry_manager_ongoing_request_migration_indefinite_failure_stream_error() {
635+
async fn _test_retry_manager_ongoing_request_migration_indefinite_failure_stream_error() {
636+
dynamo_runtime::logging::init();
630637
let request = create_mock_request(10);
631638
let mock_engine = Arc::new(MockEngine::new(
632639
MockBehavior::MidStreamFailAlwaysStreamError { fail_after: 3 },

0 commit comments

Comments
 (0)