Skip to content

Commit ac4fd87

Browse files
authored
refactor: Log subprocess stderr as WARN (#1563)
1 parent 84454ab commit ac4fd87

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

launch/dynamo-run/src/subprocess.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,11 @@ pub async fn start(
9898
tokio::spawn(async move {
9999
let mut lines = stderr.lines();
100100
while let Ok(Some(line)) = lines.next_line().await {
101-
tracing::error!("{}", strip_log_prefix(&line));
101+
// FIXME: always logging INFO/DEBUG will hide real errors, but
102+
// some libraries log non-errors to stderr, which confuses users
103+
// when we log those as ERROR. Using WARN as a middle ground for
104+
// now, but we can probably be smarter here.
105+
tracing::warn!("{}", strip_log_prefix(&line));
102106
}
103107
});
104108

0 commit comments

Comments
 (0)