Skip to content

Commit afc97ad

Browse files
committed
fix: Thanks Code Rabbit and clippy.
1 parent ad799ea commit afc97ad

File tree

5 files changed

+15
-8
lines changed

5 files changed

+15
-8
lines changed

components/frontend/src/dynamo/frontend/main.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,18 @@ def parse_args():
6060
help="KV Router: Temperature for worker sampling via softmax. Higher values promote more randomness, and 0 fallbacks to deterministic.",
6161
)
6262
parser.add_argument(
63-
"--use-kv-events",
64-
type=bool,
65-
default=True,
63+
"--kv-events",
64+
action="store_true",
65+
dest="use_kv_events",
6666
help=" KV Router: Whether to use KV events to maintain the view of cached blocks. If false, would use ApproxKvRouter for predicting block creation / deletion based only on incoming requests at a timer.",
6767
)
68+
parser.add_argument(
69+
"--no-kv-events",
70+
action="store_false",
71+
dest="use_kv_events",
72+
help=" KV Router. Disable KV events.",
73+
)
74+
parser.set_defaults(use_kv_events=True)
6875

6976
return parser.parse_args()
7077

launch/dynamo-run/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub async fn run(
4444
// Only set if user provides. Usually loaded from tokenizer_config.json
4545
.context_length(flags.context_length)
4646
.http_port(Some(flags.http_port))
47-
.router_config(flags.router_config())
47+
.router_config(Some(flags.router_config()))
4848
.request_template(flags.request_template.clone());
4949

5050
// If `in=dyn` we want the trtllm/sglang/vllm subprocess to listen on that endpoint.

lib/llm/src/discovery/model_manager.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ impl ModelManager {
212212
kv_cache_block_size: u32,
213213
kv_router_config: Option<KvRouterConfig>,
214214
) -> anyhow::Result<Arc<KvRouter>> {
215-
let selector = Box::new(DefaultWorkerSelector::new(kv_router_config.clone()));
215+
let selector = Box::new(DefaultWorkerSelector::new(kv_router_config));
216216
let chooser = KvRouter::new(
217217
component.clone(),
218218
kv_cache_block_size,

lib/llm/src/discovery/watcher.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ impl ModelWatcher {
220220
&model_entry.name,
221221
&component,
222222
card.kv_cache_block_size,
223-
self.kv_router_config.clone(),
223+
self.kv_router_config,
224224
)
225225
.await?;
226226
let kv_push_router = KvPushRouter::new(router, chooser);
@@ -261,7 +261,7 @@ impl ModelWatcher {
261261
&model_entry.name,
262262
&component,
263263
card.kv_cache_block_size,
264-
self.kv_router_config.clone(),
264+
self.kv_router_config,
265265
)
266266
.await?;
267267
let kv_push_router = KvPushRouter::new(router, chooser);

lib/llm/src/entrypoint/input/http.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ pub async fn run(runtime: Runtime, engine_config: EngineConfig) -> anyhow::Resul
4242
etcd_client.clone(),
4343
MODEL_ROOT_PATH,
4444
router_config.router_mode,
45-
Some(router_config.kv_router_config.clone()),
45+
Some(router_config.kv_router_config),
4646
)
4747
.await?;
4848
}

0 commit comments

Comments
 (0)