Skip to content

Commit cf2006b

Browse files
whoisjhhzhang16
authored andcommitted
feat: Remove Duplicate Multimodel Nixl Connect Example (#2622)
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
1 parent 0c46eea commit cf2006b

File tree

6 files changed

+11
-1824
lines changed

6 files changed

+11
-1824
lines changed

container/Dockerfile.vllm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ RUN uv pip install maturin[patchelf]
291291

292292
USER $USERNAME
293293
ENV HOME=/home/$USERNAME
294-
ENV PYTHONPATH=$PYTHONPATH:$HOME/dynamo/components/planner/src:$PYTHONPATH
294+
ENV PYTHONPATH=$PYTHONPATH:$HOME/dynamo/components/planner/src
295295
ENV CARGO_TARGET_DIR=$HOME/dynamo/.build/target
296296
WORKDIR $HOME
297297

examples/multimodal/components/encode_worker.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
from vllm.engine.arg_utils import AsyncEngineArgs
2828
from vllm.utils import FlexibleArgumentParser
2929

30+
import dynamo.nixl_connect as connect
3031
from dynamo.runtime import DistributedRuntime, dynamo_worker
3132
from dynamo.runtime.logging import configure_dynamo_logging
3233

3334
sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), ".."))
34-
import connect
3535
from utils.args import Config, base_parse_args, parse_endpoint
3636
from utils.image_loader import ImageLoader
3737
from utils.protocol import MyRequestOutput, vLLMMultimodalRequest
@@ -149,7 +149,7 @@ async def generate(
149149
descriptor = connect.Descriptor(embeddings)
150150

151151
with self._connector.create_readable(descriptor) as readable:
152-
request.serialized_request = readable.to_serialized()
152+
request.serialized_request = readable.metadata()
153153
# Clear the image URL as hint that the image is passed as embeddings.
154154
request.image_url = None
155155

@@ -190,7 +190,7 @@ async def async_init(self, runtime: DistributedRuntime):
190190

191191
# Create and initialize a dynamo connector for this worker.
192192
# We'll needs this to move data between this worker and remote workers efficiently.
193-
self._connector = connect.Connector(runtime=runtime, namespace=parsed_namespace)
193+
self._connector = connect.Connector()
194194
await self._connector.initialize()
195195

196196
logger.info("Startup completed.")

examples/multimodal/components/worker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
from vllm.utils import FlexibleArgumentParser
3333
from vllm.v1.engine.async_llm import AsyncLLM
3434

35+
import dynamo.nixl_connect as connect
3536
from dynamo.llm import ZmqKvEventPublisher, ZmqKvEventPublisherConfig
3637
from dynamo.runtime import Component, DistributedRuntime, Endpoint, dynamo_worker
3738
from dynamo.runtime.logging import configure_dynamo_logging
3839

3940
sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), ".."))
40-
import connect
4141
from publisher import StatLoggerFactory
4242
from utils.args import (
4343
Config,
@@ -250,7 +250,7 @@ async def async_init(self, runtime: DistributedRuntime):
250250
# Create and initialize a dynamo connector for this worker.
251251
# We'll needs this to move data between this worker and remote workers efficiently.
252252
parsed_namespace, _, _ = parse_endpoint(self.endpoint)
253-
self._connector = connect.Connector(runtime=runtime, namespace=parsed_namespace)
253+
self._connector = connect.Connector()
254254
await self._connector.initialize()
255255

256256
# embeddings_shape, self.embeddings_dtype = get_vision_embeddings_info(

0 commit comments

Comments
 (0)