Skip to content

Commit e13000b

Browse files
committed
address comments
1 parent 9b0d9dd commit e13000b

File tree

4 files changed

+8
-20
lines changed

4 files changed

+8
-20
lines changed

lib/bindings/python/rust/llm/block_manager/vllm/connector/leader.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use crate::llm::block_manager::{
1515
vllm::KvbmRequest, VllmBlockManager,
1616
};
1717
use crate::DistributedRuntime as PyDistributedRuntime;
18-
use dynamo_runtime::metrics::prometheus_names::kvbm_connector_namespace;
18+
use dynamo_runtime::metrics::prometheus_names::kvbm_connector;
1919

2020
use dynamo_llm::block_manager::{
2121
block::{
@@ -104,7 +104,7 @@ impl KvConnectorLeader {
104104
let drt = drt.inner().clone();
105105

106106
let ns = drt
107-
.namespace(kvbm_connector_namespace::KVBM_CONNECTOR_LEADER)
107+
.namespace(kvbm_connector::KVBM_CONNECTOR_LEADER)
108108
.unwrap();
109109

110110
let kvbm_metrics = KvbmMetrics::new(&ns);

lib/bindings/python/rust/llm/block_manager/vllm/connector/worker.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use crate::{
1616
llm::block_manager::distributed::VllmTensor, to_pyerr,
1717
DistributedRuntime as PyDistributedRuntime,
1818
};
19-
use dynamo_runtime::metrics::prometheus_names::kvbm_connector_namespace;
19+
use dynamo_runtime::metrics::prometheus_names::kvbm_connector;
2020

2121
use anyhow;
2222
use dynamo_llm::block_manager::distributed::{KvbmWorker, KvbmWorkerConfig};
@@ -93,7 +93,7 @@ impl KvConnectorWorker {
9393
.detach();
9494

9595
let kvbm_metrics = KvbmMetrics::new(
96-
&drt.namespace(kvbm_connector_namespace::KVBM_CONNECTOR_WORKER)
96+
&drt.namespace(kvbm_connector::KVBM_CONNECTOR_WORKER)
9797
.unwrap(),
9898
);
9999

lib/llm/src/block_manager/metrics_kvbm.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,5 @@
11
// SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
3-
//
4-
// Licensed under the Apache License, Version 2.0 (the "License");
5-
// you may not use this file except in compliance with the License.
6-
// You may obtain a copy of the License at
7-
//
8-
// http://www.apache.org/licenses/LICENSE-2.0
9-
//
10-
// Unless required by applicable law or agreed to in writing, software
11-
// distributed under the License is distributed on an "AS IS" BASIS,
12-
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13-
// See the License for the specific language governing permissions and
14-
// limitations under the License.
153

164
use dynamo_runtime::metrics::MetricsRegistry;
175
use prometheus::IntCounter;

lib/runtime/src/metrics/prometheus_names.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ pub mod work_handler {
133133
pub const REQUEST_DURATION_SECONDS: &str = "request_duration_seconds";
134134
}
135135

136-
/// KVBM connector namespace names
137-
pub mod kvbm_connector_namespace {
138-
/// KVBM connector leader namespace
136+
/// KVBM connector
137+
pub mod kvbm_connector {
138+
/// KVBM connector leader
139139
pub const KVBM_CONNECTOR_LEADER: &str = "kvbm_connector_leader";
140140

141-
/// KVBM connector worker namespace
141+
/// KVBM connector worker
142142
pub const KVBM_CONNECTOR_WORKER: &str = "kvbm_connector_worker";
143143
}

0 commit comments

Comments
 (0)