chore: Remove service_name from ModelDeploymentCard

We had two names in the ModelDeploymentCard: display_name and
service_name. They were either always identical, or service_name was a
[slug](https://sentry.io/answers/slug-in-django/)-ified version of the
display_name.

Having two names is confusing, especially for #2267 .

Now we only have `display_name`. The HTTP server gets to decide how to
translate that to the `model` HTTP field (if at all), it's not in the
card. In practice it still uses a slug.

Most of the code change in here is because I merged
`model_card/create.rs` and `model_card/model.rs`. It always confused me
why the object and it's implementation should be in separate files
(modules). It confused Rust too, we had to make fields `pub` just to access them.
I suspect it was a pattern from a different language mis-applied to Rust. Is fixed.

Author: grahamking

lib/llm/src/backend.rs

@@ -1,17 +1,5 @@
 // SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
 
 //! Backend
 //!
@@ -33,7 +21,7 @@ use anyhow::{Error, Result};
 use futures::stream::{self, StreamExt};
 use tracing as log;
 
-use crate::model_card::model::{ModelDeploymentCard, TokenizerKind};
+use crate::model_card::{ModelDeploymentCard, TokenizerKind};
 use dynamo_runtime::{
     pipeline::{
         async_trait, AsyncEngineContextProvider, ManyOut, Operator, ResponseStream,

lib/llm/src/local_model.rs

@@ -251,12 +251,15 @@ impl LocalModel {
         &self.full_path
     }
 
+    /// Human friendly model name. This is the correct name.
     pub fn display_name(&self) -> &str {
         &self.card.display_name
     }
 
+    /// The name under which we make this model available over HTTP.
+    /// A slugified version of the model's name, for use in NATS, etcd, etc.
     pub fn service_name(&self) -> &str {
-        &self.card.service_name
+        self.card.slug().as_ref()
     }
 
     pub fn request_template(&self) -> Option<RequestTemplate> {

lib/llm/src/migration.rs

@@ -1,17 +1,5 @@
 // SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
 
 use std::sync::Arc;
 
@@ -23,7 +11,7 @@ use async_nats::client::{
 };
 
 use crate::{
-    model_card::model::ModelDeploymentCard,
+    model_card::ModelDeploymentCard,
     protocols::common::llm_backend::{LLMEngineOutput, PreprocessedRequest},
 };