Commit 2a88836
authored
Build and container fixes for aarch64 (#408)
* Fix gds_path default
CUDA provides symlinks to correct GDS lib and include directories so there
is no need to hardcode full path that is architecture-dependent. Set
default GDS path to point to CUDA install directory and use 'include' and
'lib64' symlinks.
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
* Fix container build to properly support x86 and Arm
Currently the build script and Docker build file assume that the container
is built on x86_64 Linux host (by not specifying a platform which makes
docker default to host architecture, hardcoding 'x86_64' in several places,
etc.), which makes it impossible to create either x86_64 or aarch64
container on Arm host or aarch64 container on x86 host.
Configure target architecture via 'ARCH' docker variable. Set it to x86 by
default in Dockerfile (for any users that use it directly) and to host
architecture in build-container.sh. Allow user to specify ARCH value via
'--arch' CLI parameter, set docker build platform value accordingly and
pass the value to docker build as a build arg.
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
* Fix nixlbench container build to properly support x86 and Arm
Similar to nixl library container infrastructure nixlbench also does not
specify a docker build platform, hardcodes 'x86_64' in several places and
assumes x86 manylinux platform which makes it impossible to build anything
on aarch64 host or for aarch64 target.
Configure target architecture via 'ARCH' docker variable. Set it to x86 by
default in nixlbench Dockerfile (for any users that use it directly) and to
host architecture in build-container.sh. Allow user to specify ARCH value
via '--arch' CLI parameter, set docker build platform value accordingly and
pass the value to docker build as a build arg.
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
---------
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>1 parent b1c22ed commit 2a88836
File tree
6 files changed
+54
-19
lines changed- benchmark/nixlbench/contrib
- contrib
- src/plugins/cuda_gds
6 files changed
+54
-19
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | | - | |
| 79 | + | |
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
| |||
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
107 | | - | |
108 | | - | |
109 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
39 | 42 | | |
40 | 43 | | |
41 | 44 | | |
| |||
108 | 111 | | |
109 | 112 | | |
110 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
111 | 123 | | |
112 | 124 | | |
113 | 125 | | |
| |||
147 | 159 | | |
148 | 160 | | |
149 | 161 | | |
| 162 | + | |
150 | 163 | | |
151 | 164 | | |
152 | 165 | | |
| |||
161 | 174 | | |
162 | 175 | | |
163 | 176 | | |
| 177 | + | |
164 | 178 | | |
165 | 179 | | |
166 | 180 | | |
| |||
178 | 192 | | |
179 | 193 | | |
180 | 194 | | |
| 195 | + | |
181 | 196 | | |
182 | 197 | | |
183 | 198 | | |
184 | | - | |
| 199 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | | - | |
| 61 | + | |
61 | 62 | | |
62 | | - | |
63 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
64 | 68 | | |
65 | 69 | | |
66 | | - | |
| 70 | + | |
67 | 71 | | |
68 | 72 | | |
69 | 73 | | |
| |||
110 | 114 | | |
111 | 115 | | |
112 | 116 | | |
113 | | - | |
114 | | - | |
115 | | - | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
116 | 120 | | |
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
120 | 124 | | |
121 | 125 | | |
122 | | - | |
| 126 | + | |
123 | 127 | | |
124 | 128 | | |
125 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
| |||
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
87 | 99 | | |
88 | 100 | | |
89 | 101 | | |
| |||
103 | 115 | | |
104 | 116 | | |
105 | 117 | | |
106 | | - | |
| 118 | + | |
107 | 119 | | |
108 | 120 | | |
109 | 121 | | |
| |||
117 | 129 | | |
118 | 130 | | |
119 | 131 | | |
| 132 | + | |
120 | 133 | | |
121 | 134 | | |
122 | 135 | | |
| |||
129 | 142 | | |
130 | 143 | | |
131 | 144 | | |
| 145 | + | |
132 | 146 | | |
133 | 147 | | |
134 | 148 | | |
| |||
151 | 165 | | |
152 | 166 | | |
153 | 167 | | |
| 168 | + | |
154 | 169 | | |
155 | 170 | | |
156 | 171 | | |
157 | | - | |
| 172 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments