Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTION.md #244

Open
artalar opened this issue Oct 26, 2020 · 7 comments
Open

Add CONTRIBUTION.md #244

artalar opened this issue Oct 26, 2020 · 7 comments

Comments

@artalar
Copy link
Contributor

artalar commented Oct 26, 2020

Please, add CONTRIBUTION.md with a description of how to and where add changes, build, run performance tests.

@ai
Copy link
Owner

ai commented Oct 26, 2020

Please send PR (not avoid obvious thing focusing on difference in the project).

To run them you need to call node ./test/benchmark.js.

@artalar
Copy link
Contributor Author

artalar commented Oct 26, 2020

@ai
The problem is that I don't get your development flow and can't understand it shortly %)
I spend ~20min on trying to set changes to the code but got nothing. I did not find a build script and suggested that it doing by size-limit.., I try to del some code from index.js, but did not see any changes after restart size-limit script.
So... Please, describe it yourself. For me, two main questions are: what file is main and original (I found many copies of the same code) and how to rebuild it.

@ai
Copy link
Owner

ai commented Oct 26, 2020

what file is main and original (I found many copies of the same code) and how to rebuild it.

There is no way to re-build it. You need to copy-paste code between files.

This is why there is no origin.

@naftalmm
Copy link

@ai
As far as I get it, size-limit analizes size of index.browser.js, async/index.browser.js & non-secure/index.js files.
Does it make sence to optimize size of other production files (index.js, async/index.js, async/index.native.js)? I see there comments about some size-optimizing tricks, but I don't see a nice automated way to proof size decrease.

@ai
Copy link
Owner

ai commented Oct 31, 2020

Does it make sence to optimize size of other production files (index.js, async/index.js, async/index.native.js)?

Nope

I see there comments about some size-optimizing tricks, but I don't see a nice automated way to proof size decrease.

It is just the result of copy-pasting the description and already optimized code from browser’s versions

Repository owner deleted a comment from Oxgen66 Jun 6, 2023
@Beraliv
Copy link
Contributor

Beraliv commented Oct 20, 2023

@ai is it still helpful to have CONTRIBUTION.md? I'm happy to create a PR for it if you don't mind

@ai
Copy link
Owner

ai commented Oct 20, 2023

@Beraliv do you think we need one? Looks like the project is stable and do not need new feature or many contributions these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants