-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite_vss issue #60
sqlite_vss issue #60
Conversation
merge from main
Signed-off-by: MarcoMandar <malicemandar@gmail.com>
merge from main
This would resolve #37 Review Q: should we just remove all of the *_vcc rather than commenting it out? |
Thank you for this, I'll try to test on win32-x64 Also for future PR's, please consider reading https://github.com/ai16z/eliza/blob/main/CONTRIBUTING.md#pull-requests |
Testing instructions:
Note that the bot should start normally and give a new message:
If this what's expected, then I think this is good to merge. I have it running on my window machine without WSL. As stated before though, I think we should probably remove the _vcc stuff that's commented out to keep the code cleaner before merging. |
testing this further through discord I recieved the followign error:
|
Signed-off-by: MarcoMandar <malicemandar@gmail.com>
can you check if it is working now? |
yes that seems to have fixed the issue for me :) |
I can't test this because I don't have a windows machine, @sirkitree if it works, please merge it |
Thanks for this @MarcoMandar ! Now we have windows compatibility :) I did a quick follow-up commit to remove some of the code you commented out. |
No description provided.