feat: Updated characters types, Discord & Telegram enhancements #957
Conversation
monilpat
changed the title
| @@ -69,6 +71,102 @@ export class MessageManager { | |||
| return; | |||
| } | |||
|
|
|||
| const isDirectlyMentioned = this._isMessageForMe(message); | |||
There was a problem hiding this comment.
please add a check if discord settings is even configured before doing discord settings logic
| } | ||
|
|
||
| private _isTeamCoordinationRequest(content: string): boolean { | ||
| const coordinationKeywords = [ |
There was a problem hiding this comment.
let's move this to a constant's file
| @@ -32,6 +32,7 @@ import { sendMessageInChunks, canSendMessage } from "./utils.ts"; | |||
|
|
|||
| export type InterestChannels = { | |||
| [key: string]: { | |||
| currentHandler: any; | |||
azep-ninja
changed the title
|
Updated, fixed items, and added security feature for Telegram to limit bot add to groups, which if not wanted could get excessive usage of bot, leading to increased costs. |
|
@azep-ninja this is great stuff, but would it be possible / not too painful to break up some of the more opinionated changes from the more general stuff? Like the telegram group and team stuff should probably be separate PRs for evaluation. |
@lalalune yeah I can do that! This PR is now updated for the more generic items and separate PRs have been created below for team specific settings per client. |
azep-ninja
changed the title
|
All issues resolved here as well @odilitime . |
azep-ninja
deleted the
discord-telegram-team-agents-and-optimizations
branch
Relates to:
Issue 399
Risks
Low: Additional settings to character.json types are low level changes, and should not break any core functionality. Additionally discord messages.ts and telegram file additions are specific to the new settings, so risk is low.
Background
What does this PR do?
Enhances the Discord and Telegram bot's message handling to support:
What kind of change is this?
Features (non-breaking change which adds functionality)
Improvements (misc. changes to existing features)
Documentation changes needed?
My changes require a change to the project documentation.
Add documentation for new shouldRespondOnlyToMentions config option
Add documentation for new shouldOnlyJoinInAllowedGroups config option
Testing
Where should a reviewer start?
Detailed testing steps
ninja_dev - Discord Username