Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwrap #899

Open
dayeon5470 opened this issue Nov 20, 2024 · 1 comment
Open

Remove unwrap #899

dayeon5470 opened this issue Nov 20, 2024 · 1 comment

Comments

@dayeon5470
Copy link

dayeon5470 commented Nov 20, 2024 •
edited by kimhanbeom
Loading

Background

  • The development rules for our product say that we should use expect instead of unwrap in situations where we are confident that panic will not necessarily occur.

Task

  • Remove unwrap(), which is used against the rules
@sophie-cluml
Copy link
Contributor

@dayeon5470 We should not mention private links.

@dayeon5470 dayeon5470 changed the title Remove unwrap & Add clippy lint option to check the use of unwrap Remove unwrap & Add clippy lint option to check the use of unwrap Nov 20, 2024
@kimhanbeom kimhanbeom changed the title Remove unwrap & Add clippy lint option to check the use of unwrap Remove unwrap Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dayeon5470 @sophie-cluml