Add conversion for response to GitHubIssue

- Define struct `GitHubIssueResponse` and implement `TryFrom<T>` trait
  to parse/convert GitHub API response
- Add few implementations of `From<T>` trait to convert contents of
  struct `GitHubIssueResponse` to struct `GitHubIssue`

Author: JonghoKim-jj

src/api/issue.rs

@@ -10,11 +10,8 @@ use serde::{Deserialize, Serialize};
 use crate::{
     api,
     api::DateTimeUtc,
-    database::{self, Database, TryFromKeyValue},
-    outbound::{
-        issues::{IssueState, PullRequestState},
-        GitHubIssue,
-    },
+    database::{self, Database, GitHubIssue, TryFromKeyValue},
+    outbound::issues::{IssueState, PullRequestState},
 };
 
 scalar!(IssueState);
@@ -241,7 +238,7 @@ impl IssueQuery {
 
 #[cfg(test)]
 mod tests {
-    use crate::{api::TestSchema, outbound::GitHubIssue};
+    use crate::{api::TestSchema, database::GitHubIssue};
 
     fn create_issues(n: usize) -> Vec<GitHubIssue> {
         (1..=n)

src/api/issue_stat.rs

@@ -77,10 +77,10 @@ impl IssueStatQuery {
 mod tests {
     use jiff::Timestamp;
 
-    use crate::{api::TestSchema, outbound::GitHubIssue};
+    use crate::{api::TestSchema, database::GitHubIssue};
 
     fn create_issues(n: usize) -> Vec<GitHubIssue> {
-        (0..n)
+        (1..=n)
             .map(|i| GitHubIssue {
                 number: i.try_into().unwrap(),
                 ..Default::default()

src/database.rs

@@ -6,13 +6,12 @@ use regex::Regex;
 use serde::Serialize;
 
 pub mod discussion;
+pub mod issue;
 
 pub(crate) use discussion::DiscussionDbSchema;
+pub(crate) use issue::GitHubIssue;
 
-use crate::{
-    api::{issue::Issue, pull_request::PullRequest},
-    outbound::{GitHubIssue, GitHubPullRequestNode},
-};
+use crate::{api::pull_request::PullRequest, outbound::GitHubPullRequestNode};
 
 const GLOBAL_PARTITION_NAME: &str = "global";
 const ISSUE_PARTITION_NAME: &str = "issues";
@@ -86,19 +85,6 @@ impl Database {
         bail!("Failed to get db value");
     }
 
-    pub(crate) fn insert_issues(
-        &self,
-        resp: Vec<GitHubIssue>,
-        owner: &str,
-        name: &str,
-    ) -> Result<()> {
-        for item in resp {
-            let keystr: String = format!("{owner}/{name}#{}", item.number);
-            Database::insert(&keystr, item, &self.issue_partition)?;
-        }
-        Ok(())
-    }
-
     pub(crate) fn insert_pull_requests(
         &self,
         resp: Vec<GitHubPullRequestNode>,
@@ -112,15 +98,6 @@ impl Database {
         Ok(())
     }
 
-    pub(crate) fn issues(&self, start: Option<&[u8]>, end: Option<&[u8]>) -> Iter<Issue> {
-        let start = start.unwrap_or(b"\x00");
-        if let Some(end) = end {
-            Iter::new(self.issue_partition.range(start..end))
-        } else {
-            Iter::new(self.issue_partition.range(start..))
-        }
-    }
-
     pub(crate) fn pull_requests(
         &self,
         start: Option<&[u8]>,