Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project need to adapt latest imgui tables API #33

Closed
ice1000 opened this issue Dec 16, 2020 · 4 comments
Closed

Project need to adapt latest imgui tables API #33

ice1000 opened this issue Dec 16, 2020 · 4 comments

Comments

@ice1000
Copy link

ice1000 commented Dec 16, 2020

When I try to build this project with USE_IMGUI_TABLES defined and latest master imgui, some flags are said not to exist. I guess that's because the upstream tables API are renamed, like ocornut/imgui#2957 (comment) (and there are more).

Can we adapt the latest changes? Thanks!
@ice1000
Copy link
Author

ice1000 commented Dec 16, 2020

Also, inline ImGuiListClipper(int items_count, float items_height = -1.0f) is obsolete. You may consider using Begin(int items_count, float items_height = -1.0f) instead.

@aiekick
Copy link
Owner

aiekick commented Dec 16, 2020

ok i was not aware of these changes. i will check and correct that tonight :)

@ice1000
Copy link
Author

ice1000 commented Dec 16, 2020

Thank you very much!

@aiekick
Copy link
Owner

aiekick commented Dec 16, 2020

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aiekick @ice1000