Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an empty dictionary as the default for the repository_metadata column of DbNode #4893

Closed
sphuber opened this issue Apr 29, 2021 · 0 comments · Fixed by #4898
Closed

Use an empty dictionary as the default for the repository_metadata column of DbNode #4893

sphuber opened this issue Apr 29, 2021 · 0 comments · Fixed by #4898
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release topic/database-schema topic/orm type/refactoring
Milestone
v2.0.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Apr 29, 2021 •
edited by chrisjsewell
Loading

Currently it is null. The front-end ORM Node.repository_metadata returns an empty dictionary if the database value is None so one always gets the same type. However, if code goes around the front-end ORM, such as by using the QueryBuilder or what the import export functionality currently does, it needs to start checking the type.

fixes #4892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release topic/database-schema topic/orm type/refactoring
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Database schema: set {} as default for DbNode.repository_metadata sphuber/aiida-core
1 participant
@sphuber