Transport: SshTransport bug in method rename

[khsrali]

There seems to be a bug in method rename of class SshTransport.

The code takes two arguments, old_path and new_path. Before renaming first, checks if the new_path does not exist it raises an OSError.

This seem to be a mistake.

    def rename(self, oldpath: TransportPath, newpath: TransportPath):
        """Rename a file or folder from oldpath to newpath.

        :param str oldpath: existing name of the file or folder
        :param str newpath: new name for the file or folder

        :raises OSError: if oldpath/newpath is not found
        :raises ValueError: if sroldpathc/newpath is not a valid path
        """
        if not oldpath:
            raise ValueError(f'Source {oldpath} is not a valid path')
        if not newpath:
            raise ValueError(f'Destination {newpath} is not a valid path')

        oldpath = str(oldpath)
        newpath = str(newpath)

        if not self.isfile(oldpath):
            if not self.isdir(oldpath):
                raise OSError(f'Source {oldpath} does not exist')

        if not self.isfile(newpath):
            if not self.isdir(newpath):
                raise OSError(f'Destination {newpath} does not exist')

        return self.sftp.rename(oldpath, newpath)

[ayushjariyal]

@khsrali Is this issue still open? I want to try this issue.

[khsrali]

@ayushjariyal, yes it's open! go ahead and open a PR
Feel free to ping me, for a review :-)
Cheers!

[ayushjariyal]

@khsrali I have opened a PR. Could you please review it and let me know if any further improvements are needed?