Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit checking of existence of retrieved folders in the parsers #577

Closed
sphuber opened this issue Oct 9, 2020 · 0 comments · Fixed by #580
Closed

Remove explicit checking of existence of retrieved folders in the parsers #577

sphuber opened this issue Oct 9, 2020 · 0 comments · Fixed by #580

Comments

@sphuber
Copy link
Contributor

sphuber commented Oct 9, 2020

As of aiida-core==1.4.0, the engine itself will check for the presence of the retrieved folder. If it is missing, which is really just a bug in aiida-core the engine will terminate the process and not call the parser. Anyway there would be no point since there is nothing to parse. This means that now if the parser is called, it is guaranteed that the retrieve folder exists and so we no longer have to explicitly check for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant