Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PwBaseWorkChain validation of resources is incorrect #682

Closed
sphuber opened this issue May 5, 2021 · 0 comments · Fixed by #683
Closed

PwBaseWorkChain validation of resources is incorrect #682

sphuber opened this issue May 5, 2021 · 0 comments · Fixed by #683

Comments

@sphuber
Copy link
Contributor

sphuber commented May 5, 2021

It assumes that num_machines and max_wallclock_seconds are set, however, this only applies to certain schedulers. For example for the SgeScheduler you cannot specify num_machines so the workchain is fundamentally incompatible with those schedulers. The solution is simple: just remove the validator. The reason is that this validator was added at a time when the resources for the scheduler were not yet validated in aiida-core. But now they are (should check starting from what version) so now we can just rely on this, and even better, the validation will happen on instantiation and not when the workchain starts running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant