Replies: 4 comments
-
aiken/crates/uplc/src/builder.rs Line 137 in 67986d9 Although can't see that this is actually used |
Beta Was this translation helpful? Give feedback.
-
hmm let's discuss more but I think ordering everything is fine. |
Beta Was this translation helpful? Give feedback.
-
Happy to move to a discussion The later builtins are more involved with addtional And then there's the additional cases of I don't know what's best for these, but I think there's enough builtins that this would be better somewhat rationalized |
Beta Was this translation helpful? Give feedback.
-
All the other bytestrings are bytearrays here aiken/crates/uplc/src/builder.rs Line 141 in 67986d9 An asside and a bit too late in the day but: the use of |
Beta Was this translation helpful? Give feedback.
-
What is your idea? Provide a use case.
More explicitly:
Make the methods
aiken/crates/uplc/src/builder.rs
Line 153 in 67986d9
Stay in lock step with
aiken/crates/uplc/src/builtins.rs
Line 15 in 67986d9
With
PascalCase -> snake_case
Why is it a good idea?
It'll be easier to maintain and for others to use if it reflects the builtins as they are elsewhere.
Don't have to remember
Subtract
issub
and thatMultiplyInteger
doesnt have a builder.And if it did it's clear where in the list it ought to appear
What is the current alternative and why is it not good enough?
Keep things ad hoc and inexhaustive so people are put off trying to use them.
Beta Was this translation helpful? Give feedback.
All reactions