Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Broken #289

Closed
norvig opened this issue Mar 1, 2017 · 7 comments
Closed

Build Broken #289

norvig opened this issue Mar 1, 2017 · 7 comments

Comments

@norvig
Copy link
Collaborator

norvig commented Mar 1, 2017

Somewhere along the way the build got broken. Would like to see it fixed again!

@kshitij10496
Copy link

The commit 9f7f4df started breaking the build.
Also, we need to check whether the commits merged after 9f7f4df (namely, 0e46096 and 123571e) are building properly.
I will try to fix it up.

@reachtarunhere
Copy link
Collaborator

The issue was due to Travis + Setuptools and not due to our code. The build works now. Another Project - Same Issue

I just had to press rebuild on Travis to get this working. No change in config was required.

@antmarakis
Copy link
Collaborator

It seems that the issue is still not fixed, I'm afraid. I made a trivial pull request (fixing typos in comments) but Travis could not built.

@reachtarunhere
Copy link
Collaborator

reachtarunhere commented Mar 1, 2017

@MrDupin Yeah the build still fails occasionally. I am looking into it. I feel adding six to the travis config file should work. On the other hand I am also getting this warning that Travis is suffering from outages on public repos so that might be a cause too.

@reachtarunhere
Copy link
Collaborator

This issue has been fixed but I can't find a way to restart builds for old PRs with new config file. Anyone has any idea how to go about this?

@antmarakis
Copy link
Collaborator

antmarakis commented Mar 2, 2017

If new PRs work, we could make new PRs for the old ones (at least, the ones that we want to commit). I checked a few of them and it wouldn't be too much work.

Also, I checked my PR, #294, and it built successfully. Maybe it now works for others too?

@reachtarunhere
Copy link
Collaborator

It will work for PRs with recent commits and it might or might not for the older PRs. I guess we can safely close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants