Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I enforce CORS despite middlewares? #481

Open
louisabraham opened this issue May 14, 2024 · 0 comments
Open

How can I enforce CORS despite middlewares? #481

louisabraham opened this issue May 14, 2024 · 0 comments

Comments

@louisabraham
Copy link

I implemented authentication on my app with this code:

@middleware
async def auth(request, handler):
    if request.headers.get("Authorization") == f"Bearer {TOKEN}":
        return await handler(request)
    return web.Response(status=401)

The problem is that OPTIONS requests don't contain authentication headers (https://stackoverflow.com/a/40723041/5133167), and the middleware doesn't return the CORS headers.

I could solve my issue by adding a condition:

@middleware
async def auth(request, handler):
    # skip auth for OPTIONS requests
    if (
        request.method == "OPTIONS"
        or request.headers.get("Authorization") == f"Bearer {TOKEN}"
    ):
        return await handler(request)
    return web.Response(status=401)

but I think it's ugly and that users shouldn't have to deal with this.

Is there a general way to enforce CORS on any middleware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant