Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_extra_info for ClientWebSocketResponse #1717

Closed
kdub0 opened this issue Mar 15, 2017 · 3 comments
Closed

get_extra_info for ClientWebSocketResponse #1717

kdub0 opened this issue Mar 15, 2017 · 3 comments
Labels
outdated

Comments

@kdub0
Copy link

kdub0 commented Mar 15, 2017

I'd like to be able to retrieve the server's certificate from an https websocket. Right now, this is possible with something like:

async with aiohttp.ws_connect(url) as ws:
    cert = ws._conn.writer.get_extra_info('peercert')

Is there a way to do this that is future proof? or can the API be extended to expose the websocket's transport?

Thanks!
@fafhrd91
Copy link
Member

makes sense. I added get_extra_info to ClientWebSocketResponse in master
I do not think we should allow access to transport object.

@kdub0
Copy link
Author

kdub0 commented Mar 15, 2017

Awesome, much appreciated!

@kdub0 kdub0 closed this as completed Mar 15, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fafhrd91 @kdub0