Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response.text() crash if body contain non UTF-8 symbol #1802

Closed
Dexus77 opened this issue Apr 9, 2017 · 3 comments
Closed

response.text() crash if body contain non UTF-8 symbol #1802

Dexus77 opened this issue Apr 9, 2017 · 3 comments
Labels

Comments

@Dexus77
Copy link

Dexus77 commented Apr 9, 2017

Long story short

Unfortunately the world is not perfect.
Server in body UTF-8 can return non UTF-8 character.

Content-Type: text/html; charset=utf-8

Error: utf-8' codec can't decode byte 0x80 in position 19404: invalid start byte

Expected behaviour

Actual behaviour

Steps to reproduce

Your environment

@kxepal
Copy link
Member

kxepal commented Apr 9, 2017

I guess, for imperfect servers you should use .read() instead and satinize all the bad symbols in the way you think it's right. I don't think there is a good strategy to deal with non UTF-8 symbols in UTF-8 response except to raise an exception.

@Dexus77
Copy link
Author

Dexus77 commented Apr 9, 2017

OK. Thanks for the quick reply.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants