Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Can the changelog link to the GitHub issue? #2888

Closed
Mariatta opened this issue Mar 28, 2018 · 6 comments
Closed

Documentation: Can the changelog link to the GitHub issue? #2888

Mariatta opened this issue Mar 28, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@Mariatta
Copy link
Member

Long story short

In the changelog, I see references to GitHub issue numbers.
For example, the changelog entry for 3.1.0:

3.1.1 (2018-03-27)
Support asynchronous iterators (and asynchronous generators as well) in both
client and server API as request / response BODY payloads. (#2802)

I suspect #2802 refers to GitHub issue number #2802. Would be nice if that is linked.

Expected behaviour

#2802 links to #2802 so readers can easily look up the issue.

Actual behaviour

#2802 was just a plain text.

Thanks.

@asvetlov asvetlov self-assigned this Mar 28, 2018
@asvetlov asvetlov added this to the 3.2 milestone Mar 28, 2018
@asvetlov
Copy link
Member

I like the idea.
Can be done easily.
I'll try to fix the changelog on making the next release.

@asvetlov
Copy link
Member

asvetlov commented Apr 6, 2018

Unfortunately, the problem is a little more complex than I expected.
I thought it can be solved by simple regex but #xxxx can point either on issue or on pull request.
Need to use github API for resolving.
Will do it soon anyway, just postponed yesterday to not block the release.

@samuelcolvin
Copy link
Member

samuelcolvin commented Apr 6, 2018

Simple fix: just link to https://github.com/aio-libs/aiohttp/pull/XXX and it will redirect if that number is an issue. eg. https://github.com/aio-libs/aiohttp/pull/288 will redirect to this issue.

@samuelcolvin
Copy link
Member

see here for how I do it in pydantic, I'm sure there's a more sophisticated way of doing it but that works.

@asvetlov
Copy link
Member

Fixed by 96e09c6
@samuelcolvin thanks for the idea

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants