Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.0 release #3118

Closed
samuelcolvin opened this issue Jul 2, 2018 · 18 comments
Closed

3.4.0 release #3118

samuelcolvin opened this issue Jul 2, 2018 · 18 comments
Assignees
Labels

Comments

@samuelcolvin
Copy link
Member

samuelcolvin commented Jul 2, 2018

Please can we have a new release.

In particular, I need #3062, since it's a bug and there's no easy workaround for it.

The 3.3 milestone has a lot of stuff on it, if there's no plan to release for a while, perhaps #3062 would be backported as a patch?

@kxepal
Copy link
Member

kxepal commented Jul 2, 2018

We already have 3.3.2 release. Did you mean 3.4.0?

@samuelcolvin
Copy link
Member Author

sorry, yes.

@samuelcolvin samuelcolvin changed the title 3.3.0 release 3.4.0 release Jul 2, 2018
@samuelcolvin
Copy link
Member Author

@asvetlov?

@asvetlov
Copy link
Member

asvetlov commented Jul 8, 2018

Sorry, was pretty busy last weeks.
Yes, it's time for aiohttp 3.4
Please let me review open issues first.
Maybe we can close some of them quickly.

@samuelcolvin
Copy link
Member Author

Great, sorry to hassle.

@webknjaz
Copy link
Member

I think I've adjusted CIs to produce wheels for 3.7 as well ;)

@asvetlov
Copy link
Member

Cool!

@samuelcolvin
Copy link
Member Author

bump, any update on this? I'm still waiting on #3062.

@asvetlov
Copy link
Member

The showstopper is: I'd like to publish a new multidict release with Python 3.7 wheels first.
Now we have problems with building macosx wheels on Travis.
@webknjaz is working on it but still no success (after that I expect the same fix for aiohttp itself is needed).
As an alternative, we can drop MacOSX wheels entirely (very tempting solution BTW)

@webknjaz
Copy link
Member

@asvetlov that issue is related to me breaking Travis config during migration to tox. This one should be good to go.

@kxepal
Copy link
Member

kxepal commented Aug 10, 2018

@webknjaz offtopic a bit, but why tox? No trolling, just curiouosity.

@webknjaz
Copy link
Member

It's defacto standard. I know that there's some pitfalls and @asvetlov personally does not like it. That's why we're testing this in multidict, which is smaller. Andrew also asked me to investigate pyinvoke.
Other thing to take into account is that contributions are most likely to be proficient with tox and unfamiliar with other tools.
There's already some tox configs, which some contributors try to maintain on their own, which is sad, because it would be more straightforward if we followed some popular practices. Also, for Andrew, I've wrapped calls to tox via Makefile.

@kxepal
Copy link
Member

kxepal commented Aug 10, 2018

Thanks! Going to join on watching this experiment. I had tried tox once upon a time, but things turned too much complicated with no oblivious profit /: May be today will be different picture or I'd missed something.

@webknjaz
Copy link
Member

@kxepal tox still tends to be complicated :(
However, it would let us achieve the long-term goal of unification, where users will be able to run the same envs/tests as CIs.
Also, this makes it better portable across CIs whenever you want to migrate/add new ones.
Among nice things: virtualenv caching/reuse/isolation (different env for each task by default, can be changed; reuse of settings from other envs; env matrix generation (so-called factors).

@samuelcolvin
Copy link
Member Author

Released

@asvetlov
Copy link
Member

@samuelcolvin sorry for the long waiting

@samuelcolvin
Copy link
Member Author

No problem, we all have busy lives.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants